KEMBAR78
FROMGIT: media: venus: hfi: add check to handle incorrect queue size (0c2468e1) · Commits · CodeLinaro / la / kernel / msm-5.4 · GitLab
Skip to content
Commit 0c2468e1 authored by Vikash Garodia's avatar Vikash Garodia
Browse files

FROMGIT: media: venus: hfi: add check to handle incorrect queue size



qsize represents size of shared queued between driver and video
firmware. Firmware can modify this value to an invalid large value. In
such situation, empty_space will be bigger than the space actually
available. Since new_wr_idx is not checked, so the following code will
result in an OOB write.
...
qsize = qhdr->q_size

if (wr_idx >= rd_idx)
 empty_space = qsize - (wr_idx - rd_idx)
....
if (new_wr_idx < qsize) {
 memcpy(wr_ptr, packet, dwords << 2) --> OOB write

Add check to ensure qsize is within the allocated size while
reading and writing packets into the queue.

Cc: stable@vger.kernel.org
Fixes: d96d3f30 ("[media] media: venus: hfi: add Venus HFI files")
Reviewed-by: default avatarBryan O'Donoghue <bryan.odonoghue@linaro.org>
CRs-Fixed: 3935673
Change-Id: Ifb907d4a4c82f853081492e06e68180476367ed5
Git-commit: 69baf245
Git-repo: https://gitlab.freedesktop.org/linux-media/media-committers.git


Signed-off-by: default avatarVikash Garodia <quic_vgarodia@quicinc.com>
parent 288c2bc2
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment