-
Notifications
You must be signed in to change notification settings - Fork 108
Add/examples #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add/examples #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ip.yml Co-Authored-By: Alec Rust <me@alecrust.com>
peterwilsoncc
previously approved these changes
Jan 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Adding line breaks to the end of each of the yaml files would be nice but isn't a blocker.
Relative links in markdown file work as expected.
|
@tarecord might be nice to get your well-commented version added as an example as well? |
Add comments to example file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR moves our current set of example workflow files into an
examplesdirectory, references those from the readme file, and pulls the additional example from #69 into that directory.Note that this replaces work from #69.
How to test the Change
Preview with markdown previewer.
Changelog Entry
Credits
Props @AlecRust, @helen, @jeffpaul.
Checklist: