KEMBAR78
Add/examples by jeffpaul · Pull Request #143 · 10up/action-wordpress-plugin-deploy · GitHub
Skip to content

Conversation

@jeffpaul
Copy link
Member

@jeffpaul jeffpaul commented Jan 3, 2024

Description of the Change

This PR moves our current set of example workflow files into an examples directory, references those from the readme file, and pulls the additional example from #69 into that directory.

Note that this replaces work from #69.

How to test the Change

Preview with markdown previewer.

Changelog Entry

Added - Example workflow files to documentation.

Credits

Props @AlecRust, @helen, @jeffpaul.

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@jeffpaul jeffpaul added this to the 2.3.0 milestone Jan 3, 2024
@jeffpaul jeffpaul self-assigned this Jan 3, 2024
@jeffpaul jeffpaul requested a review from a team as a code owner January 3, 2024 17:10
@jeffpaul jeffpaul requested review from peterwilsoncc and removed request for a team January 3, 2024 17:10
peterwilsoncc
peterwilsoncc previously approved these changes Jan 7, 2024
Copy link
Contributor

@peterwilsoncc peterwilsoncc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Adding line breaks to the end of each of the yaml files would be nice but isn't a blocker.

Relative links in markdown file work as expected.

@jeffpaul
Copy link
Member Author

jeffpaul commented Jan 8, 2024

@tarecord might be nice to get your well-commented version added as an example as well?

@tarecord
Copy link
Contributor

tarecord commented Jan 8, 2024

@jeffpaul do you want me to fork and add that? I added a PR anyway.

@jeffpaul jeffpaul merged commit dae7bd0 into develop Jan 8, 2024
@jeffpaul jeffpaul deleted the add/examples branch January 8, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants