KEMBAR78
Update action examples to install svn by thrijith · Pull Request #155 · 10up/action-wordpress-plugin-deploy · GitHub
Skip to content

Conversation

@thrijith
Copy link
Member

Description of the Change

  • Update action examples to install svn

Closes #151

Checklist:

@thrijith thrijith requested a review from a team as a code owner October 24, 2024 12:33
@thrijith thrijith requested review from iamdharmesh and jeffpaul and removed request for a team October 24, 2024 12:33
@jeffpaul jeffpaul added this to the 2.3.0 milestone Oct 24, 2024
@jeffpaul jeffpaul removed their request for review October 24, 2024 14:23
Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thrijith,

Thanks a lot for the PR, it looks good to me. Just a minor suggestion around installing the package, based on GH action docs. Could you please check it once?

Thank you.

Copy link
Member

@iamdharmesh iamdharmesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @thrijith. @dkotter Could you please help with a quick check and merge as I have made minor change to the PR.

@dkotter dkotter merged commit 02ae50a into develop Nov 22, 2024
1 check failed
@dkotter dkotter deleted the feature/update-action-examples branch November 22, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ubuntu-latest lo longer comes with SVN installed

4 participants