fix eval when using subset host loading data #951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aireenmei
force-pushed
the
aireen/fix_eval
branch
from
3c96a3b to
781eb0e
Compare
aireenmei
requested review from
bvandermoon,
gobbleturk,
jonb377,
khatwanimohit and
vipannalla
as code owners
ZhiyuLi-goog
reviewed
Oct 7, 2024
|
Hi, @aireenmei Awesome and thank you for the fix! Do we expect to unblock |
|
@ZhiyuLi-goog It should support eval_per_device_batch_size < 1. But let me actually run the tests to make sure. Will get back to you. |
ZhiyuLi-goog
approved these changes
Oct 11, 2024
khatwanimohit
approved these changes
Oct 11, 2024
| TRAIN_CMD="python3 MaxText/train.py MaxText/configs/base.yml \ | ||
| steps=$STEPS eval_steps=$EVAL_STEPS eval_interval=$STEPS \ | ||
| per_device_batch_size=8.0 learning_rate=3e-4 enable_checkpointing=false \ | ||
| per_device_batch_size=1.0 learning_rate=3e-4 enable_checkpointing=false \ |
There was a problem hiding this comment.
do we want to change the per device batch size here ?
There was a problem hiding this comment.
Thank you for catching it! This is for my testing only and shouldn't be checked in. I removed it.
aireenmei
force-pushed
the
aireen/fix_eval
branch
2 times, most recently
from
e400f7b to
45fc74d
Compare
add process_indices_eval
aireenmei
force-pushed
the
aireen/fix_eval
branch
from
45fc74d to
28741d6
Compare
|
@ZhiyuLi-goog I reliazed _tfds_data_processing_c4_mlperf.py also needs update. Please review my latest push^. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/371572923
Tested on v4-128: https://cloudlogging.app.goo.gl/YqjMDsc27SxXHSLaA