on mouse hover show / hide modal image viewer icons #14291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Perfect thanks! |
|
For a user who doesn't know about those elements at top it could be difficult to find out about them if they are invisible. Maybe a setting toggle? |
|
I implemented a strange method of making it optional |
I think a CSS variable is absolutely fine for this 👍 |
AUTOMATIC1111
approved these changes
Jan 1, 2024
AUTOMATIC1111
deleted the
on-mouse-hover-show-hide-modal-image-viewer-icons
branch
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
future request #14288 Fullscreen Preview control fading/disable.
for mouse usere, show and hide fullscreen image viewer icon on mouse hover
this CSS is only in effect when using Mouse, so mobile are not affected
personally I think it looks better when it's automatically hidden
but ideally they should be an option to toggle this behavior, currently I haven't figured out how to do so
demo video
2023-12-13.01_59_20_248.chrome.mp4
Checklist: