KEMBAR78
hires button, fix seeds by w-e-w · Pull Request #14598 · AUTOMATIC1111/stable-diffusion-webui · GitHub
Skip to content

hires button, fix seeds #14598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2024
Merged

hires button, fix seeds #14598

merged 1 commit into from
Jan 9, 2024

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Jan 9, 2024

Description

follow up of 15ec54d Have upscale button use the same seed as hires fix.

that doesn't actually work
seed is set by the seed script in the setup()
too late to modify it using modules.scripts.scripts_txt2img.set_named_arg, I have to directly modify p.seed

you forget about sub seeds

I've been having trouble getting all 3 out put
normal hires fix (the old input accordion)
manual hires fix (txt2img -> upscale -> image)
and 2 stage hires fix (this nuw button)
to be the match (pixel perfect)

at this point I am not sure if I messed up or has something changed

Checklist:

@w-e-w w-e-w requested a review from AUTOMATIC1111 as a code owner January 9, 2024 16:58
@AUTOMATIC1111
Copy link
Owner

Wait, really? I was sure it worked when I tested it. Not the subseed part, but the seed did match. I added set_named_arg specifically to make it work.

@AUTOMATIC1111
Copy link
Owner

Oh, it must be because of the txt2img_create_processing. So it would work on commit you linked, but broke later.

@AUTOMATIC1111 AUTOMATIC1111 merged commit 85bf2eb into dev Jan 9, 2024
@AUTOMATIC1111 AUTOMATIC1111 deleted the fix-txt2img_upscale branch January 9, 2024 17:05
@w-e-w
Copy link
Collaborator Author

w-e-w commented Jan 9, 2024 •
edited
Loading

ahh it makes sense now txt2img_create_processing
I was confused I think I saw it working for a bit then certainly doesn't work and then I couldn't figure out why so I just assumed that it was not working originally

@w-e-w w-e-w mentioned this pull request Feb 17, 2024
Closed
@pawel665j pawel665j mentioned this pull request Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AUTOMATIC1111 AUTOMATIC1111 AUTOMATIC1111 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@w-e-w @AUTOMATIC1111