Improve test cases to test header-less response #822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gladjohn
reviewed
May 15, 2025
gladjohn
approved these changes
May 15, 2025
|
looks good @rayluo. just one minor clarification comment. |
neha-bhargava
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSAL has long been allowing callers to specify their own http client. Early versions of MSAL Python did not require that http client's response to contain headers. This PR changes the test helper to mimic a header-less response by default, so that our existing test cases will automatically cover header-less response scenarios. This can help preventing regression.
P.S.
Issue #817 was created in an aftermath of such a regression. This PR precisely covers those scenarios; therefore, it can resolve #817.
(End-to-end tests, while being useful in their own right, would not be enough to guard against this kind of "header-less response regression", because real e2e requests are typically sent with real http clients that always contain headers.)
Lastly, note that this PR changes only a couple of files in the "./tests" directory. It does not alter any existing MSAL behavior. It is a low-risk PR.