KEMBAR78
BREAKING: junit: Add support for BeforeEach and AfterEach methods by fmeum · Pull Request #833 · CodeIntelligenceTesting/jazzer · GitHub
Skip to content

Conversation

@fmeum
Copy link
Contributor

@fmeum fmeum commented Aug 28, 2023

No description provided.

@fmeum fmeum marked this pull request as draft August 28, 2023 13:21
@fmeum
Copy link
Contributor Author

fmeum commented Aug 28, 2023

Stacked on #832, but otherwise ready for review.

@fmeum fmeum requested a review from a team August 28, 2023 13:22
@fmeum fmeum force-pushed the FUZZ-763-support-lifecycle-methods branch from bc72b18 to b6f2fd5 Compare August 29, 2023 12:04
@fmeum fmeum marked this pull request as ready for review August 29, 2023 12:05
@fmeum fmeum changed the title junit: Add support for BeforeEach and AfterEach methods BREAKING: junit: Add support for BeforeEach and AfterEach methods Aug 29, 2023
Copy link
Contributor

@bertschneider bertschneider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments, great addition 👍

@fmeum fmeum force-pushed the FUZZ-763-support-lifecycle-methods branch 2 times, most recently from dbdf815 to cdc6ab2 Compare August 30, 2023 15:01
@fmeum fmeum requested a review from bertschneider August 30, 2023 15:01
@fmeum fmeum enabled auto-merge (rebase) August 31, 2023 10:32
@fmeum fmeum disabled auto-merge August 31, 2023 10:34
@fmeum fmeum force-pushed the FUZZ-763-support-lifecycle-methods branch 2 times, most recently from 66c77ce to 1186fe3 Compare September 1, 2023 09:54
During fuzzing, methods annotated with `@BeforeEach` or `@AfterEach` as
well as implementations of `BeforeEachCallback` and `AfterEachCallback`
are now executed between individual fuzz test executions rather than
only once before and after fuzzing. This more closely matches the
behavior of JUnit unit tests as well as fuzz tests in regression test
mode.
@fmeum fmeum force-pushed the FUZZ-763-support-lifecycle-methods branch from 1186fe3 to 3da61da Compare September 1, 2023 09:55
@fmeum fmeum enabled auto-merge (rebase) September 1, 2023 09:56
@fmeum fmeum merged commit 1ca007d into main Sep 1, 2023
@fmeum fmeum deleted the FUZZ-763-support-lifecycle-methods branch September 1, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants