-
Notifications
You must be signed in to change notification settings - Fork 162
BREAKING: junit: Add support for BeforeEach and AfterEach methods #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stacked on #832, but otherwise ready for review. |
bc72b18 to
b6f2fd5
Compare
bertschneider
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor comments, great addition 👍
examples/junit/src/test/java/com/example/LifecycleFuzzTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/driver/FuzzTargetFinder.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/driver/LibFuzzerLifecycleMethodsInvoker.java
Outdated
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/junit/JUnitLifecycleMethodsInvoker.java
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/junit/JUnitLifecycleMethodsInvoker.java
Show resolved
Hide resolved
src/main/java/com/code_intelligence/jazzer/junit/JUnitLifecycleMethodsInvoker.java
Show resolved
Hide resolved
dbdf815 to
cdc6ab2
Compare
bertschneider
approved these changes
Aug 31, 2023
66c77ce to
1186fe3
Compare
During fuzzing, methods annotated with `@BeforeEach` or `@AfterEach` as well as implementations of `BeforeEachCallback` and `AfterEachCallback` are now executed between individual fuzz test executions rather than only once before and after fuzzing. This more closely matches the behavior of JUnit unit tests as well as fuzz tests in regression test mode.
1186fe3 to
3da61da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.