-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Migrate Linux CI to GCC 12 #20609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Linux CI to GCC 12 #20609
Conversation
|
Thanks @cho-m! Can I get a sense of what this would enable/unblock for us to upgrade? |
I mainly want to migrate to remove workarounds I added to use This avoids an unnecessary dependency and Ubuntu's GCC may be faster. GCC 12 should also allow us to bottle In terms of user impact:
Footnotes |
|
@cho-m Thanks for explaining! As long as we can handle the from-bottle case automatically that'd be ideal. The from source case we may want a It's also worth thinking here about when/whether we want to move to Ubuntu 24.04. I suspect the answer is "no, not yet" but we'll need to in ~1.5 years. |
No strong opinion here. Anytime from Apr 2026 (26.04 release date) to Apr 2027 (end of standard support) should be fine. May want to prepare advance notice to make sure users are aware of plan. |
We can communicate "at some point after X we will ...". We can't really commit to dates years out given a volunteer team 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few more comments.
b42ed19 to
2988231
Compare
|
Pushed some updates for review comments but will need to do more local testing to make sure they work.
Yeah, not a hard deadline. Just a rough timeframe as glibc upgrade can cause unexpected issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now looks great to me, nice work @cho-m!
@cho-m Agreed. Would you be able to pick up a first draft for this? Could be either in Support Tiers (there's similar stuff for macOS at the bottom) or Homebrew on Linux docs. |
|
Container seems okay with quick build and formula install attempt. Removing Removing Spun up a clean Rocky 9 container to see output: And Ubuntu 16.04: |
|
Can wait a couple days in case some issues show up for other commits. I will also try building formulae on docker image. |
|
Should be ready to review. May want to wait for Tahoe bottling to slow down before merge so there is less CI activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge when Tahoe bottling complete!
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
|
Merging as Tahoe bottling has slowed down (first pass done, no bottle jobs) and GNOME formulae are starting to fail with GCC 11. Can try to fix forward any failures we hit in Homebrew/core. |
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Exploring changes needed for this.