KEMBAR78
Enable strict typing in SystemCommand by dduugg · Pull Request #20613 · Homebrew/brew · GitHub
Skip to content

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Aug 31, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Part of #17297

This one has some definite tradeoffs:

  • No more implicit multiple assignment of the command result, need to call to_a
  • I removed the kwargs splat to type them individually. I think this is also great for code completion, but there's a lot of duplicated type declarations as a resul.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few questions!

@dduugg dduugg force-pushed the dug/typed-system-command branch from 8acd0e2 to fb6c51d Compare September 2, 2025 17:26
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Sep 8, 2025
@MikeMcQuaid
Copy link
Member

Thanks!

Merged via the queue into main with commit efc036f Sep 8, 2025
36 checks passed
@MikeMcQuaid MikeMcQuaid deleted the dug/typed-system-command branch September 8, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants