SkipConditions: check disabled before deprecated #20622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have some formulae and casks that contain both `deprecate!` and `disable!` calls, presumably as a way of controlling the deprecation behavior before the disable date is reached. However, once the disable date has been reached, `Livecheck::SkipConditions` continues to skip the package as deprecated instead of disabled. This isn't a functional issue as the package is still skipped but it isn't accurate because it's not being skipped as disabled. This reorders `FORMULA_CHECKS` and `CASK_CHECKS` to run the disabled check before the deprecated check, so the disable date will take precedence when it's been reached.
bevanjkay
approved these changes
Sep 2, 2025
MikeMcQuaid
deleted the
livecheck/SkipConditions-check-disabled-before-deprecated
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?We have some formulae and casks that contain both
deprecate!anddisable!calls, presumably as a way of controlling the deprecation behavior before the disable date is reached. However, once the disable date has been reached,Livecheck::SkipConditionscontinues to skip the package as deprecated instead of disabled. This isn't a functional issue as the package is still skipped but it isn't accurate because it's not being skipped as disabled.This reorders
FORMULA_CHECKSandCASK_CHECKSto run the disabled check before the deprecated check, so the disable date will take precedence when it's been reached.