livecheck: support trailing comments in watchlist #20623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-linnane
approved these changes
Sep 2, 2025
MikeMcQuaid
approved these changes
Sep 3, 2025
I ran `brew livecheck` today to check the packages in my watchlist and realized that it wasn't checking one package because I had added a trailing comment after the name (and `package # Comment` isn't a valid package name). I thought we had added support for trailing comments when we originally added comment support years back but I must have been mistaken. This adds support for trailing comments in livecheck watchlist files as part of refactoring the watchlist line parsing logic to only use one pass (instead of multiple `#map` and `#reject` calls). This maintains the existing behavior, where blank lines and lines starting with `#` are skipped, but does so in a more flexible manner. For example, the existing logic wouldn't skip a comment line that has one or more spaces before the `#` character but this new logic will correctly skip it.
samford
force-pushed
the
livecheck/support-trailing-comments-in-watchlist
branch
from
f5e354d to
31cf8b4
Compare
MikeMcQuaid
approved these changes
Sep 3, 2025
MikeMcQuaid
deleted the
livecheck/support-trailing-comments-in-watchlist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?I ran
brew livechecktoday to check the packages in my watchlist and realized that it wasn't checking one package because I had added a trailing comment after the name (andpackage # Commentisn't a valid package name). I thought we had added support for trailing comments when we originally added comment support years back but I must have been mistaken.This adds support for trailing comments in livecheck watchlist files as part of refactoring the watchlist line parsing logic to only use one pass (instead of multiple
#mapand#rejectcalls). This maintains the existing behavior, where blank lines and lines starting with#are skipped, but does so in a more flexible manner. For example, the existing logic wouldn't skip a comment line that has one or more spaces before the#character but this new logic will correctly skip it.