KEMBAR78
Use type-safe blocks by dduugg · Pull Request #20648 · Homebrew/brew · GitHub
Skip to content

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Sep 7, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The &method style undergoes type erasure, is disallowed at typed: strict, and (IMO) isn't idiomatic ruby: https://sorbet.run/#%23%20typed%3A%20strict%0A%0Anumbers%20%3D%20%5B1%2C2%2C3%5D%0A%0AT.reveal_type%28numbers.map%20%7B%20String%28_1%29%20%7D%29%0AT.reveal_type%28numbers.map%28%26method%28%3AString%29%29%29

@dduugg dduugg added this pull request to the merge queue Sep 7, 2025
Merged via the queue into main with commit 31fb2ad Sep 7, 2025
36 checks passed
@dduugg dduugg deleted the dug/type-safe-blocks branch September 7, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants