KEMBAR78
build build_environment build_options: enable `typed: strict` by botantony · Pull Request #20650 · Homebrew/brew · GitHub
Skip to content

Conversation

botantony
Copy link
Member

@botantony botantony commented Sep 8, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

#17297

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Some tweaks.

botantony and others added 4 commits September 11, 2025 06:26
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Wee request: please don't use @MikeMcQuaid (or put inside backticks or omit the @) as it sends me an email to my personal instead of Homebrew email because it's not part of the Homebrew org (but instead your fork).

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Sep 11, 2025
Merged via the queue into Homebrew:main with commit 610c67b Sep 11, 2025
36 checks passed
@botantony botantony deleted the build-typecheck branch September 11, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants