Improve superenv mixing newer LLVM headers with Apple libc++ #20653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?To avoid missing symbols when mixing newer LLVM headers with older Apple libc++, inject a __config_site that sets vendor availability annotations to match system library.
A hacky proof-of-concept to increase usability of
ENV.llvm_clangwithout LLVM runtime dependency when bottling older macOS.Also can use this PR to discuss other ideas for improving
ENV.llvm_clangto avoid having to force linkage even when unnecessary.Though we may want to figure out a solution for LLVM formula that works outside of brew since we always get user issues when new LLVM introduces annotation (some that I recall include LLVM 15 verbose abort, LLVM 18
std::printand LLVM 21std::__hash_memory)