-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
os/mac/*: typed: strict
#20660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
os/mac/*: typed: strict
#20660
Conversation
Signed-off-by: botantony <antonsm21@gmail.com>
52a697b to
c8106c6
Compare
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
Signed-off-by: botantony <antonsm21@gmail.com>
c8106c6 to
0adf859
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, thanks!
Signed-off-by: botantony <antonsm21@gmail.com> Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
5ee3eda to
98bac6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One final nit/question.
Signed-off-by: botantony <antonsm21@gmail.com> Co-authored-by: Bo Anderson <mail@boanderson.me>
98bac6e to
843fc7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?#17297