-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
feat: reinstall pkgconf automatically on macOS version mismatch #20674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aecff61 to
d3bfd65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Should be good to go when code is merged elsewhere.
d3bfd65 to
2389d78
Compare
077f572 to
78195a1
Compare
9c5ca3b to
a5b612f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, this approach is looking much better so far! A few comments, feel free to disagree with any.
aa1bed5 to
3176dd2
Compare
3176dd2 to
587433a
Compare
Thanks, @MikeMcQuaid! Your help was key to getting this working. This is my first time in this codebase and with Ruby, so if there are any other conventions or things to look out for, please let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! Wonderful work here @naboyu, I'm really impressed 👏🏻. Hopefully many more PRs incoming from you 😍
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?This PR follows up on #20418 by implementing the automatic mitigation requested in the source code comment. It
changes theadds an active repair attempt.pkgconfmacOS SDK mismatch diagnostic from a passive warning toThe diagnostic checkupdate-reportandupgradenow perform the following steps:pkgconfwas built on a different version of macOS.brew reinstall pkgconf.This provides a better user experience by solving the issue directly for the underlying problem noted in issue #16137.