cmd/shellenv: echo path helper command rather than run it. #20675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is faster at both execution and `eval`ing than the existing version and aids caching.
reitermarkus
approved these changes
Sep 12, 2025
The output of `path_helper` needs to be `eval`ed for it to work.
carlocab
force-pushed
the
shellenv_echo_path_helper
branch
from
40e6236 to
57578cf
Compare
|
Ok, thanks, agreed this seems mostly pointless then. Thanks @carlocab! |
3 tasks
|
@carlocab @MikeMcQuaid, my bad, I should have enclosed the path_helper call in eval when reporting #20671. It's fixed correctly fixed here. This does solve the caching issue and arguably gives a clearer output on what the script it actually doing without hiding the path_helper call. |
carlocab
approved these changes
Sep 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is faster at both execution and
evaling than the existing version and aids caching.Fixes #20671