KEMBAR78
formula_installer: optlink even with cask installed by cho-m · Pull Request #20680 · Homebrew/brew · GitHub
Skip to content

formula_installer: optlink even with cask installed #20680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2025
Merged

formula_installer: optlink even with cask installed #20680

merged 1 commit into from
Sep 12, 2025

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 12, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes Homebrew/homebrew-core#236514

Run cask check earlier so that we can create an optlink.

Before:

❯ brew install --quiet cmake cmake-app
==> Fetching downloads for: cmake-app
✔︎ Cask cmake-app (4.1.1)
==> Installing Cask cmake-app
==> Moving App 'CMake.app' to '/Applications/CMake.app'
==> Linking ...

==> Fetching downloads for: cmake
✔︎ Bottle Manifest cmake (4.1.1)
✔︎ Bottle cmake (4.1.1)
==> Pouring cmake--4.1.1.arm64_tahoe.bottle.tar.gz
==> cmake cask is installed, skipping link.
🍺  /opt/homebrew/Cellar/cmake/4.1.1: 3,913 files, 58.1MB

❯ brew outdated
cmake (4.1.1) < 4.1.1

❯ realpath $(which cmake)
/Applications/CMake.app/Contents/bin/cmake

❯ $(brew --prefix cmake)/bin/cmake --version
zsh: no such file or directory: /opt/homebrew/opt/cmake/bin/cmake

After:

❯ brew install --quiet cmake cmake-app
==> Fetching downloads for: cmake-app
✔︎ Cask cmake-app (4.1.1)
==> Installing Cask cmake-app
==> Moving App 'CMake.app' to '/Applications/CMake.app'
==> Linking ...

==> Fetching downloads for: cmake
✔︎ Bottle Manifest cmake (4.1.1)
✔︎ Bottle cmake (4.1.1)
==> Pouring cmake--4.1.1.arm64_tahoe.bottle.tar.gz
==> cmake cask is installed, skipping link.
🍺  /opt/homebrew/Cellar/cmake/4.1.1: 3,913 files, 58.1MB

❯ brew outdated

❯ realpath $(which cmake)
/Applications/CMake.app/Contents/bin/cmake

❯ $(brew --prefix cmake)/bin/cmake --version
cmake version 4.1.1

CMake suite maintained and supported by Kitware (kitware.com/cmake).

@cho-m cho-m mentioned this pull request Sep 12, 2025
Closed
5 tasks
@MikeMcQuaid
Copy link
Member

Thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Sep 12, 2025
Merged via the queue into main with commit d7c0052 Sep 12, 2025
36 checks passed
@MikeMcQuaid MikeMcQuaid deleted the optlink-when-cask-installed branch September 12, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZhongRuoyu ZhongRuoyu ZhongRuoyu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cmake Consistently Shows as Outdated

3 participants

@cho-m @MikeMcQuaid @ZhongRuoyu