KEMBAR78
github_runner_matrix: deploy Tahoe runner in CI by ZhongRuoyu · Pull Request #20685 · Homebrew/brew · GitHub
Skip to content

Conversation

ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Opening as draft to prepare to deploy Tahoe runner in CI when we feel comfortable.

The change here is not user-facing and thus independent of #20681.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good when we're ready.

Copy link
Member

@fxcoudert fxcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We’re now at 57% Tahoe bottle coverage, I think it makes sense to enable Tahoe on CI now, or soon anyway.

@ZhongRuoyu ZhongRuoyu marked this pull request as ready for review September 14, 2025 08:29
@ZhongRuoyu ZhongRuoyu added this pull request to the merge queue Sep 14, 2025
Merged via the queue into main with commit 5f1241b Sep 14, 2025
36 checks passed
@ZhongRuoyu ZhongRuoyu deleted the tahoe-runner branch September 14, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants