KEMBAR78
Bump some leftover RuboCops to Sorbet `typed: strict` by issyl0 · Pull Request #20687 · Homebrew/brew · GitHub
Skip to content

Bump some leftover RuboCops to Sorbet typed: strict #20687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2025
Merged

Bump some leftover RuboCops to Sorbet typed: strict #20687

merged 1 commit into from
Oct 7, 2025

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Sep 14, 2025 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

MikeMcQuaid
MikeMcQuaid approved these changes Sep 15, 2025
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good when 🟢!

@issyl0 issyl0 force-pushed the some-small-sorbet-strict-bumps branch from a00bd42 to e6b9415 Compare October 6, 2025 21:58
@issyl0 issyl0 marked this pull request as ready for review October 6, 2025 22:18
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Oct 7, 2025
@MikeMcQuaid
Copy link
Member

Thanks again @issyl0, great work!

Merged via the queue into main with commit 7c6d683 Oct 7, 2025
51 checks passed
@MikeMcQuaid MikeMcQuaid deleted the some-small-sorbet-strict-bumps branch October 7, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@issyl0 @MikeMcQuaid @Copilot