extend/os/mac/reinstall: fix pkgconf reinstall #20692
Merged
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhongRuoyu
force-pushed
the
fix-pkgconf-reinstall
branch
2 times, most recently
from
eb12257 to
e3e0d21
Compare
Before:
$ rm `brew --cache`/downloads/*pkgconf*
$ gsed -Ei 's/macOS [[:digit:]]+/macOS 14/g' `brew --prefix pkgconf`/INSTALL_RECEIPT.json
$ brew up
==> Updating Homebrew...
Already up-to-date.
Error: wrong number of arguments (given 2, expected 0)
Warning: Removed Sorbet lines from backtrace!
Rerun with `--verbose` to see the original backtrace
/opt/homebrew/Library/Homebrew/reinstall.rb:67:in 'BasicObject#initialize'
/opt/homebrew/Library/Homebrew/reinstall.rb:67:in 'Class#new'
/opt/homebrew/Library/Homebrew/reinstall.rb:67:in 'Homebrew::Reinstall.build_install_context'
/opt/homebrew/Library/Homebrew/extend/os/mac/reinstall.rb:27:in 'OS::Mac::Reinstall::ClassMethods#reinstall_pkgconf_if_needed!'
/opt/homebrew/Library/Homebrew/cmd/update-report.rb:258:in 'Homebrew::Cmd::UpdateReport#output_update_report'
/opt/homebrew/Library/Homebrew/cmd/update-report.rb:34:in 'Homebrew::Cmd::UpdateReport#run'
/opt/homebrew/Library/Homebrew/brew.rb:101:in '<main>'
Please report this issue:
https://docs.brew.sh/Troubleshooting
There are two problems here:
1. We don't require `formula_installer` in `reinstall.rb`, and it isn't
required indirectly anywhere else, so `FormulaInstaller` is
undefined.
2. We don't fetch the `pkgconf` bottle before trying to reinstall it, so
the reinstall fails because the bottle isn't available.
We fix 2. by fetching the formula before attempting to reinstall it.
Then, at the same time, by sourcing `install`, we also fix 1.
After:
$ brew up
==> Updating Homebrew...
Already up-to-date.
==> Fetching downloads for: pkgconf
✔︎ Bottle Manifest pkgconf (2.5.1)
==> Verifying attestation for pkgconf
✔︎ Bottle pkgconf (2.5.1)
==> Reinstalling pkgconf
==> Pouring pkgconf--2.5.1.arm64_tahoe.bottle.tar.gz
🍺 /opt/homebrew/Cellar/pkgconf/2.5.1: 28 files, 519.8KB
==> Reinstalled pkgconf due to macOS version mismatch
ZhongRuoyu
force-pushed
the
fix-pkgconf-reinstall
branch
from
e3e0d21 to
5f9182c
Compare
p-linnane
approved these changes
Sep 15, 2025
|
Thanks for the quick fix @ZhongRuoyu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Before:
There are two problems here:
formula_installerinreinstall.rb, and it isn't required indirectly anywhere else, soFormulaInstalleris undefined.pkgconfbottle before trying to reinstall it, so the reinstall fails because the bottle isn't available.We fix 2. by fetching the formula before attempting to reinstall it. Then, at the same time, by sourcing
install, we also fix 1.After: