KEMBAR78
chore: switch cask-ci-matrix to cask methods by SMillerDev · Pull Request #20720 · Homebrew/brew · GitHub
Skip to content

chore: switch cask-ci-matrix to cask methods #20720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2025
Merged

chore: switch cask-ci-matrix to cask methods #20720

merged 1 commit into from
Sep 18, 2025

Conversation

SMillerDev
Copy link
Member

@SMillerDev SMillerDev commented Sep 17, 2025 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

As requested in #20707 by @MikeMcQuaid

@SMillerDev SMillerDev force-pushed the chore/cask/regex_matrix branch 6 times, most recently from df5c229 to ef81375 Compare September 18, 2025 07:26
@SMillerDev SMillerDev force-pushed the chore/cask/regex_matrix branch from ef81375 to 3919bb3 Compare September 18, 2025 07:29
MikeMcQuaid
MikeMcQuaid approved these changes Sep 18, 2025
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Much nicer. Can consider adding more utility methods to provide support for this sort of thing if it makes life easier.

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Sep 18, 2025
Merged via the queue into main with commit 7e498eb Sep 18, 2025
36 checks passed
@MikeMcQuaid MikeMcQuaid deleted the chore/cask/regex_matrix branch September 18, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SMillerDev @MikeMcQuaid