KEMBAR78
Load casks from internal API by Rylan12 · Pull Request #20726 · Homebrew/brew · GitHub
Skip to content

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Sep 19, 2025

Now that we have a sharded /api/internal/cask.PLATFORM.json file, let's use that when HOMEBREW_USE_INTERNAL_API is set.

For now, there are no content differences between the internal and non-internal API files, so this is a very basic change.

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should maintainers start setting HOMEBREW_USE_INTERNAL_API to test?

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Sep 19, 2025
Merged via the queue into main with commit 290d0f5 Sep 19, 2025
36 checks passed
@MikeMcQuaid MikeMcQuaid deleted the cask-internal-api branch September 19, 2025 07:37
@Rylan12
Copy link
Member Author

Rylan12 commented Sep 19, 2025

Should maintainers start setting HOMEBREW_USE_INTERNAL_API to test?

@p-linnane, there are still some larger changes needed on the formula side of things, so I won't yet recommend/ask for it (although you're welcome to, since I'm not expecting any massive breaking changes at the moment)

I will send a message in Slack when it's time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants