KEMBAR78
Update `executables.txt` in `brew update` when needed by Rylan12 · Pull Request #20739 · Homebrew/brew · GitHub
Skip to content

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Sep 20, 2025

Now that which-formula lives in this repo, we should fetch executables.txt on brew update invocations. When a user runs brew which-formula for the first time, a setting is saved indicating that executables.txt should be downloaded on future brew update calls. If a user does not run brew which-formula, the file will not be fetched.

To make this easier, I've extracted the API file fetch logic to a helper function in update.sh. You can view that change in isolation in 1f042a3 (#20739).

I've also added --skip-update to the shell handlers that call which-formula so no new files will be downloaded if a user types the wrong command in their shell.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks again @Rylan12!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Sep 21, 2025
Merged via the queue into main with commit 98dfd75 Sep 21, 2025
54 of 58 checks passed
@MikeMcQuaid MikeMcQuaid deleted the update-executables-db branch September 21, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants