KEMBAR78
download_queue: restore `Interrupt` handling by ZhongRuoyu · Pull Request #20746 · Homebrew/brew · GitHub
Skip to content

Conversation

ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

178580a changed rescue Interrupt to plain rescue but this actually excludes Interrupt exceptions, which means that pressing Ctrl-C during a download would leave the terminal in a broken state. To see the problem, one can try e.g. brew fetch --deps qt and then press Ctrl-C immediately once the downloads start.

178580a changed `rescue Interrupt` to
plain `rescue` but this actually excludes `Interrupt` exceptions, which
means that pressing Ctrl-C during a download would leave the terminal in
a broken state. To see the problem, one can try e.g.
`brew fetch --deps qt` and then press Ctrl-C immediately once the
downloads start.
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Sep 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2025
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Sep 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2025
@ZhongRuoyu ZhongRuoyu added this pull request to the merge queue Sep 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2025
@ZhongRuoyu ZhongRuoyu added this pull request to the merge queue Sep 22, 2025
Merged via the queue into main with commit 5b23645 Sep 22, 2025
47 of 48 checks passed
@ZhongRuoyu ZhongRuoyu deleted the download-queue-rescue-interrupts branch September 22, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants