Revert "Use installed keg formula files when referencing installed formulae/dependencies" #20753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmulae/dependencies"
Rylan12
approved these changes
Sep 22, 2025
MikeMcQuaid
reviewed
Sep 22, 2025
| sig { returns(Formula) } | ||
| def latest_formula | ||
| installed_alias_target_changed? ? T.must(current_installed_alias_target) : Formulary.factory(name) | ||
| installed_alias_target_changed? ? T.must(current_installed_alias_target) : self |
There was a problem hiding this comment.
This may be the relevant T.must. I'd advise trying to remove the T.must in these cases in favour of adjusting the code to handle a nil instead.
MikeMcQuaid
deleted the
revert-20603-install-uninstall-formulae-internal-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are issues with bottling in
homebrew/core. See https://github.com/Homebrew/homebrew-core/actions/runs/17918737406/job/50948240605?pr=245265 for example.Reverts #20603