KEMBAR78
patch: use `@@HOMEBREW_PREFIX@@` placeholder in all patches by cho-m · Pull Request #20760 · Homebrew/brew · GitHub
Skip to content

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 24, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

We went with @@HOMEBREW_PREFIX@@ for external patches and I feel this is the better option to avoid chances of collisions with actual HOMEBREW_PREFIX usage.

In Homebrew/core, the only formulae this impacts is:

The latter does mean odisabled will cause issues. Will need to move patch to formula-patches to avoid this.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks!

@cho-m cho-m added this pull request to the merge queue Sep 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 25, 2025
@cho-m
Copy link
Member Author

cho-m commented Sep 25, 2025

Unrelated to PR, but from merge attempt:

For the Links > External check, the following failures were found:

* At ./_site/Command-Not-Found.html:101:

  External link https://www.gnu.org/software/bash failed: got a time out (response code 301) (status code 301)

Likely want to adjust this to avoid hitting GNU servers wherever possible since we have gotten in trouble due to excessive load.

@cho-m cho-m added this pull request to the merge queue Sep 25, 2025
Merged via the queue into main with commit b352fff Sep 25, 2025
38 checks passed
@cho-m cho-m deleted the patch-align-placeholder branch September 25, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants