KEMBAR78
formula_auditor: move `RELICENSED_FORMULAE_VERSIONS` list to tap by botantony · Pull Request #20788 · Homebrew/brew · GitHub
Skip to content

formula_auditor: move RELICENSED_FORMULAE_VERSIONS list to tap #20788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2025
Merged

formula_auditor: move RELICENSED_FORMULAE_VERSIONS list to tap #20788

merged 1 commit into from
Oct 1, 2025

Conversation

botantony
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Moving it for convenience (it is easier for Homebrew/core contributors to modify a JSON rather than look for the hash table somewhere in brew source code) and consistency (other audit exception lists are already in a tap)

This PR depends on Homebrew/homebrew-core#246437, merge it first

@botantony botantony mentioned this pull request Oct 1, 2025
Merged
6 tasks
@botantony botantony force-pushed the relicensed_formulae_versions branch from 3eb4129 to adb3855 Compare October 1, 2025 09:52
@botantony botantony changed the title formula_autitor: move RELICENSED_FORMULAE_VERSIONS list to tap formula_auditor: move RELICENSED_FORMULAE_VERSIONS list to tap Oct 1, 2025
@bevanjkay
Copy link
Member

I'm not strictly against moving this to homebrew/core - but I think this usage is quite sensitive to protect us from distributing non-open-source code, so the obscurity of it being in homebrew/brew may help it from being edited by contributors without understanding the ramifications.

p-linnane
p-linnane approved these changes Oct 1, 2025
View reviewed changes
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this. It helps our audits catch when formulae are removed (as most of these have been).

@botantony
Copy link
Member Author

@bevanjkay I might be wrong here, but I think for extra-protection we can set code ownership (similar to permitted_formula_license_mismatches.json)

https://github.com/Homebrew/homebrew-core/blob/a85454360e5cf56a4319daecf669366b34ea2fc3/CODEOWNERS#L21

@botantony botantony force-pushed the relicensed_formulae_versions branch from adb3855 to 5afba01 Compare October 1, 2025 13:18
MikeMcQuaid
MikeMcQuaid reviewed Oct 1, 2025
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me if added to CODEOWNERS 👍🏻

@botantony
formula_auditor: move RELICENSED_FORMULAE_VERSIONS list to tap
927d142 
Moving it for convenience (it is easier for Homebrew/core contributors
to modify a JSON rather than look for the hash table somewhere in brew
source code) and consistency (other audit exception lists are already in
a tap)

Signed-off-by: botantony <antonsm21@gmail.com>
@botantony botantony force-pushed the relicensed_formulae_versions branch from 5afba01 to 927d142 Compare October 1, 2025 16:22
@botantony botantony marked this pull request as ready for review October 1, 2025 16:22
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Oct 1, 2025
Merged via the queue into main with commit f8a5750 Oct 1, 2025
38 checks passed
@MikeMcQuaid MikeMcQuaid deleted the relicensed_formulae_versions branch October 1, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@p-linnane p-linnane p-linnane approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@botantony @bevanjkay @MikeMcQuaid @p-linnane