audit_min_os: only use sparkle_min_os as fallback #20813
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Cask::Audit#audit_min_osuses the minimum macOS version requirement from the app bundle and newest item in the Sparkle feed but these values are treated equally in the code. We recently came across a cask where the app specified High Sierra (10.13) as the minimum macOS version but the Sparkle appcast used 26.0.0 (Tahoe) as theminimumSystemVersionvalue, so this audit incorrectly requiresdepends_on macos: ">= :tahoe"in the cask. The app and the upstream website both advertise the 10.13 macOS requirement, so the appcast value needs to be fixed.However, this highlighted a shortcoming in the audit logic, as we probably shouldn't allow the Sparkle minimum macOS value to override what's specified in the app. This updates the logic to only fall back to the
sparkle_min_osvalue whenbundle_min_osisnil, so a higher Sparkle value won't overridebundle_min_os.