formula_auditor: get casks from API if not tapped #20816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
MikeMcQuaid
approved these changes
Oct 6, 2025
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
|
May need to check if we have a chicken-and-egg issue for tap migrations. I'm guessing cask-to-formula currently works due to lack of audit check, i.e. migration PR passes for non-existent formula Likely want to have a bypass label specific for tap migrations that will use same name. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?CoreCaskTap.instance.cask_tokenshandles 2 scenarios:Homebrew/core CI runs in a 3rd scenario, i.e. no API without Homebrew/cask tapped.
This PR does mean a network fetch may occur during
brew auditeven when no API is used. As a developer command and conditioned only for Homebrew/core formulae, I think this is okay.Could put it under
@onlinebut that seems to be for slower audits and isn't needed in CI where we've already fetched the JSON API in an earlier step.Could restrict to CI only if preferred.