KEMBAR78
keg: retain pypy directories by cho-m · Pull Request #20822 · Homebrew/brew · GitHub
Skip to content

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Oct 5, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

For similar reasons as Python along with share directory where user scripts are saved

Regex needs to match both pypy and pypy3.X so didn't include version part (it would need to be optional in which case it may as well be excluded).

If we want a more specific regex then maybe,

%r{^pypy(3\.\d+)?(/|$)}

Would depend on how likely a non-Pypy formula uses a path like lib/pypyfoo.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Oct 6, 2025
Merged via the queue into main with commit 7389b16 Oct 6, 2025
38 checks passed
@MikeMcQuaid MikeMcQuaid deleted the pypy-mkpath branch October 6, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants