KEMBAR78
utils/bottles: fix all bottle tab by cho-m · Pull Request #20831 · Homebrew/brew · GitHub
Skip to content

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Oct 7, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This is needed for @@HOMEBREW_PERL@@ to work

One thing is that it won't use versioned Perl path since the built_on in tab is still wrong.

Could do something like following if it matters

tab.built_on = DevelopmentTools.build_system_info

However the versioned Perl path is less useful for plain scripts as it breaks across macOS upgrades. It is more useful when Perl modules are required as compiled modules are incompatible with different Perl versions.


e.g. lesspipe without PR:

head -1 $(brew --prefix lesspipe)/bin/vimcolor
#!/opt/homebrew/opt/perl/bin/perl

after PR:

head -1 $(brew --prefix lesspipe)/bin/vimcolor
#!/usr/bin/perl

e.g. ack (removed postinstall) without PR

head -1 $(brew --prefix ack)/bin/ack
#!/opt/homebrew/opt/perl/bin/perl

after PR

head -1 $(brew --prefix ack)/bin/ack
#!/usr/bin/perl

This is needed for @@HOMEBREW_PERL@@ to work
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cho-m!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Oct 7, 2025
Merged via the queue into main with commit 3ae86fb Oct 7, 2025
38 checks passed
@MikeMcQuaid MikeMcQuaid deleted the fix-all-bottle-tab branch October 7, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants