bump-*-pr: skip PR creation when --write-only without --commit #20840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Homebrew#20005 fixed `--write-only` and broke `--write-only --commit` (my bad). Homebrew#20809 fixed `--write-only --commit` and broke `--write-only`. This hopefully fixes both. From the help: ``` --write-only Make the expected file modifications without taking any Git actions. --commit When passed with --write-only, generate a new commit after writing changes to the cask file. ``` So if `--write-only` is passed without `--commit`, we should skip the whole PR creation flow. But if `--write-only --commit` is passed, we should generate the branch and commit but not the PR. Refs: Homebrew#20005 Refs: Homebrew#20809 Refs: https://github.com/Homebrew/brew/pull/20818/files
|
cc/ @scientificworld as you filed the previous PR, let me know if this doesn't make sense. |
You didn't 😉. I'll fix. |
MikeMcQuaid
reviewed
Oct 9, 2025
My bad, I must have changed it again after running the checks 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?PR #20005 fixed
--write-onlyand broke--write-only --commit(my bad). #20809 fixed--write-only --commitand broke--write-only. Thishopefully fixes both.
From the help:
So if
--write-onlyis passed without--commit, we should skip thewhole PR creation flow. But if
--write-only --commitis passed, weshould generate the branch and commit but not the PR.
Refs: #20005
Refs: #20809
Refs: https://github.com/Homebrew/brew/pull/20818/files