KEMBAR78
Docs/Formula-Cookbook.md: remove `external command` mention by botantony · Pull Request #20846 · Homebrew/brew · GitHub
Skip to content

Conversation

botantony
Copy link
Member

@botantony botantony commented Oct 10, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

As test-bot is no longer an external command, I propose to change it to something different, f.e. https://github.com/DomT4/homebrew-autoupdate

Why autoupdate?

  • This is a fairly popular (1.2k stars) and useful tap that has an external command. I think this is a good and representative example of what you can do with external commands
  • It used to be a part of Homebrew and it was created by an ex-maintainer. Some current maintainers have contributed to it
  • The docs acknowledge it as an "interesting third-party tap": https://docs.brew.sh/Interesting-Taps-and-Forks#unsupported-interesting-taps

@botantony botantony force-pushed the terminology-change-external-command branch from 3470019 to 345ee3c Compare October 10, 2025 21:24
@botantony botantony changed the title Docs/Formula-Cookbook.md: change external command example Docs/Formula-Cookbook.md: remove external command mention Oct 10, 2025
Signed-off-by: botantony <antonsm21@gmail.com>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
@botantony botantony force-pushed the terminology-change-external-command branch from 345ee3c to 7533a94 Compare October 10, 2025 21:25
@p-linnane p-linnane enabled auto-merge October 11, 2025 04:57
@p-linnane p-linnane added this pull request to the merge queue Oct 11, 2025
Merged via the queue into main with commit 264cff2 Oct 11, 2025
38 checks passed
@p-linnane p-linnane deleted the terminology-change-external-command branch October 11, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants