KEMBAR78
ast_constants: add preserve_rpath by cho-m · Pull Request #20851 · Homebrew/brew · GitHub
Skip to content

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Oct 10, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Before we start using this, should decide where to put stanza.

One of following seems okay:

preserve_rpath
skip_clean "bin/foo"
link_overwrite "bin/foo", "lib/bar.so"

or

skip_clean "bin/foo"
link_overwrite "bin/foo", "lib/bar.so"
preserve_rpath

Went with former as putting preserve_rpath and skip_clean near each other makes sense to me as they handle brew's internal modifications to keg files.

And having skip_clean next to link_overwrite as both take a list of files.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid enabled auto-merge October 10, 2025 15:49
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Oct 10, 2025
Merged via the queue into main with commit 5b88dc0 Oct 10, 2025
38 checks passed
@MikeMcQuaid MikeMcQuaid deleted the preserve_rpath-order branch October 10, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants