KEMBAR78
sorbet: Don't include comments or line numbers in generated RBI files by issyl0 · Pull Request #20855 · Homebrew/brew · GitHub
Skip to content

sorbet: Don't include comments or line numbers in generated RBI files #20855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2025
Merged

sorbet: Don't include comments or line numbers in generated RBI files #20855

merged 2 commits into from
Oct 13, 2025

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Oct 10, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • I saw these options in a thread in the Sorbet Slack and was interested in what they'd do for us.
  • Theoretically it decreases the churn in the generated RBI files. I'm not sure it's worth it. Curious what others think?

issyl0 and others added 2 commits October 10, 2025 23:19
@issyl0
sorbet: Don't include comments or line numbers in generated RBI files
a1c4ba0 
- This decreases the churn in the updates of the RBI files.
- I saw these options in a thread in the Sorbet Slack and was interested
  in what they'd do for us.
@p-linnane
Merge branch 'main' into do-we-care-this-much-about-rbi-docs
e41edb5
MikeMcQuaid
MikeMcQuaid approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Oct 13, 2025
Merged via the queue into main with commit c7a8ae2 Oct 13, 2025
40 checks passed
@MikeMcQuaid MikeMcQuaid deleted the do-we-care-this-much-about-rbi-docs branch October 13, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@issyl0 @MikeMcQuaid @p-linnane @Copilot