Move brew portable-package to brew test-bot
#20874
Merged
+41
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was already the only caller and this should improve the output a fair bit too.
There was a problem hiding this comment.
Pull Request Overview
This PR removes the standalone brew portable-package command and integrates its functionality directly into the brew test-bot system. The command was only used internally by test-bot, so consolidating it improves the output and simplifies the codebase.
- Removes the
portable-packagecommand and its shell completions - Moves portable package building logic into the test-bot formulae module
- Integrates portable formula handling into the existing test-bot workflow
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| completions/zsh/_brew | Removes zsh completion for portable-package command |
| completions/internal_commands_list.txt | Removes portable-package from internal commands list |
| completions/fish/brew.fish | Removes fish completion for portable-package command |
| completions/bash/brew | Removes bash completion for portable-package command |
| Library/Homebrew/test_bot/formulae.rb | Adds portable_formula! method and integrates portable package logic |
| Library/Homebrew/dev-cmd/portable-package.rb | Deletes the entire standalone command file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
p-linnane
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already the only caller and this should improve the output a fair bit too.