cask/audit: fix min_os audit on arm64 #20899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bevanjkay
force-pushed
the
cask-min-os-audit
branch
from
96cedf3 to
9a270b0
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the minimum macOS version audit for casks on ARM64 hardware. Previously, the audit was incorrectly skipping validation when a cask had on_system blocks on ARM, even when the application required a newer macOS version than what the cask specified.
Key changes:
- Modified the audit skip condition to compare
app_min_oswithcask_min_osinstead of checking ifcask_min_os < macOS 11
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?On arm hardware we were always skipping the audit result when there was no
cask_min_osset, because it is automatically set to Catalina. This line adds an additional check for cases where a newer version is required by the application that is set by the cask before skipping.