KEMBAR78
util-linux: fix build, add LDFLAGS="-lm" on Linux by jacktose · Pull Request #235572 · Homebrew/homebrew-core · GitHub
Skip to content

util-linux: fix build, add LDFLAGS="-lm" on Linux #235572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2025
Merged

util-linux: fix build, add LDFLAGS="-lm" on Linux #235572

merged 1 commit into from
Aug 31, 2025

Conversation

@jacktose
Copy link
Contributor

@jacktose jacktose commented Aug 30, 2025 •
edited
Loading

This was attempted in #214529, but not actually fixed. This changes the approach from an environment variable to a make command argument. Full explanation in discussion.

Closes https://github.com/orgs/Homebrew/discussions/5421

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?
Install & test results 
$ brew uninstall --force util-linux

$ brew install --build-from-source util-linux --only-dependencies
...

$ HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source util-linux
==> Fetching downloads for: util-linux
==> Fetching util-linux
==> Downloading https://github.com/util-linux/util-linux/commit/45f943a4b36f59814cf5a735e4975f2252afac26.patch?full_index=1
Already downloaded: /home/jacktose/.cache/Homebrew/downloads/6044fe7f1f251a5ea2f51e816024257d0306b1f0a96600daefa42791decd657e--45f943a4b36f59814cf5a735e4975f2252afac26.patch
==> Downloading https://github.com/util-linux/util-linux/commit/565eb6370c76721bbd0d7fa292d9315a6856f627.patch?full_index=1
Already downloaded: /home/jacktose/.cache/Homebrew/downloads/0ce740c8bfb56ee839b57801f29c447b0623e6d4dc85a7e393f7a8b9e61b5aa0--565eb6370c76721bbd0d7fa292d9315a6856f627.patch
==> Downloading https://mirrors.edge.kernel.org/pub/linux/utils/util-linux/v2.41/util-linux-2.41.1.tar.xz
Already downloaded: /home/jacktose/.cache/Homebrew/downloads/fb2bf25e6a14d80fc8745c951ab9a77c73feb7f56c1b520f00f2f4b3bc39d0fe--util-linux-2.41.1.tar.xz
==> Patching
==> Applying 45f943a4b36f59814cf5a735e4975f2252afac26.patch
==> Applying 565eb6370c76721bbd0d7fa292d9315a6856f627.patch
==> autoreconf --force --install --verbose
==> ./configure --disable-silent-rules --disable-asciidoc --with-bashcompletiondir=/home/linuxbrew/.linuxbrew/Cellar/util-linux/2.41.1_1/etc/bash_completion.d --disable-use-tty-group --disable-kill --without-s
==> make install
🍺  /home/linuxbrew/.linuxbrew/Cellar/util-linux/2.41.1_1: 447 files, 26.2MB, built in 38 seconds
==> Running `brew cleanup util-linux`...
Disable this behaviour by setting `HOMEBREW_NO_INSTALL_CLEANUP=1`.
Hide these hints with `HOMEBREW_NO_ENV_HINTS=1` (see `man brew`).
Removing: /home/jacktose/.cache/Homebrew/util-linux_bottle_manifest--2.40.4... (17.5KB)
Removing: /home/jacktose/.cache/Homebrew/util-linux--2.41.1.tar.xz... (9.2MB)
Removing: /home/jacktose/.cache/Homebrew/util-linux--patch--3945234bcfbf4d9126e92b4f808029971ab26330618da53671941ba1a52d8427.patch... (634B)
Removing: /home/jacktose/.cache/Homebrew/util-linux--patch--b372a7578ff397787f37e1aa1c03c8299c9b3e3f7ab8620c4af68c93ab2103b5.patch... (1.5KB)
==> No outdated dependents to upgrade!
==> Caveats
Bash completion has been installed to:
  /home/linuxbrew/.linuxbrew/etc/bash_completion.d
==> Installation times
util-linux               36.797 s

$ brew test util-linux
==> Testing util-linux
==> /home/linuxbrew/.linuxbrew/Cellar/util-linux/2.41.1_1/bin/namei -lx /usr

$ brew audit --strict util-linux

$ brew style util-linux

1 file inspected, no offenses detected

gist logs

Alternatives: @cho-m is working on a more general fix in #235571. If that's accepted and solves this issue (I'll be thrilled and) we won't need this, nor #214529.
I suggest merging this simple fix now, then backing out both when #235571 lands.
(If you don't want this fix now, I suggest backing out #214529, and I'll just keep my brew edit util-linux version until the general fix lands.)

@jacktose jacktose mentioned this pull request Aug 30, 2025
Merged
6 tasks
@jacktose jacktose marked this pull request as ready for review August 30, 2025 04:02
carlocab
carlocab reviewed Aug 30, 2025
View reviewed changes
@carlocab carlocab added CI-skip-dependents Pass --skip-dependents to brew test-bot. CI-no-bottles Merge without publishing bottles labels Aug 30, 2025
@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. automerge-skip `brew pr-automerge` will skip this pull request labels Aug 30, 2025
@jacktose @carlocab
util-linux: fix build, add LDFLAGS="-lm" on Linux
8c873a1 
This was attempted in Homebrew#214529, but not actually fixed. This changes the
approach from an environment variable to a `make` command argument. Full
explanation in discussion:
https://github.com/orgs/Homebrew/discussions/5421#discussioncomment-14260165

Closes https://github.com/orgs/Homebrew/discussions/5421

Co-authored-by: Carlo Cabrera <github@carlo.cab>
@github-actions github-actions bot removed automerge-skip `brew pr-automerge` will skip this pull request autosquash Automatically squash pull request commits according to Homebrew style. labels Aug 31, 2025
@jacktose jacktose requested a review from carlocab August 31, 2025 01:13
@BrewTestBot BrewTestBot added this pull request to the merge queue Aug 31, 2025
Merged via the queue into Homebrew:main with commit 3e0eab3 Aug 31, 2025
28 checks passed
@jacktose
Copy link
Contributor Author

Thanks!

@jacktose
Copy link
Contributor Author

jacktose commented Sep 3, 2025

For the record, #235571 was merged, but I still fail to build util-linux without LDFLAGS=-lm, so I don't think this should be backed out.

Details in discussion #5421.

@jacktose jacktose mentioned this pull request Sep 6, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlocab carlocab carlocab approved these changes

Assignees

No one assigned

Labels

CI-no-bottles Merge without publishing bottles CI-skip-dependents Pass --skip-dependents to brew test-bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jacktose @carlocab @BrewTestBot