lsr: remove using argument #235750
Merged
lsr: remove using argument #235750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
zig
samford
force-pushed
the
lsr-remove-using-argument
branch
from
755427e to
195f8a5
Compare
I added support to `DownloadStrategyDetector` for tangled.sh Git URLs, so the `using: :git` argument in the `lsr` formula is (or will be) redundant. This formula will fail `brew audit` (after we remove the exception to skip the related audit for `lsr`), so this removes the argument. Besides that, this modifies the formula to use `zig@14`, as the build will fail with errors otherwise (i.e., `expected function or variable declaration after pub` for `build.zig` lines like `pub usingnamespace @import("src/zeit.zig");` and `pub usingnamespace zzdoc;`).
samford
force-pushed
the
lsr-remove-using-argument
branch
from
195f8a5 to
9175395
Compare
|
The aforementioned |
carlocab
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?I added support to
DownloadStrategyDetectorfor tangled.sh Git URLs (Homebrew/brew#20599), so theusing: :gitargument in thelsrformula is (or will be) redundant. This formula would normally failbrew auditas a result but the related audit is currently being skipped forlsr(it was necessary to be able to merge the relatedbrewPR). I've created this as a draft until the aforementionedDownloadStrategyDetectorchange is in a brew release.Besides that, this modifies the formula to use
zig@14, as the build will fail with errors otherwise (i.e.,expected function or variable declaration after pubforbuild.ziglines likepub usingnamespace @import("src/zeit.zig");andpub usingnamespace zzdoc;).