KEMBAR78
fix: import PolarsDataframeSerializer by bednar · Pull Request #105 · InfluxCommunity/influxdb3-python · GitHub
Skip to content

Conversation

@bednar
Copy link
Member

@bednar bednar commented Aug 12, 2024

Closes #104

Proposed Changes

Fixed import of the PolarsDataframeSerializer.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.08%. Comparing base (65d64e2) to head (6a14269).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   54.44%   55.08%   +0.63%     
==========================================
  Files          33       33              
  Lines        2046     2046              
==========================================
+ Hits         1114     1127      +13     
+ Misses        932      919      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josiahschuller
Copy link

Thanks @bednar for your very quick actions to make a fix for this!

@bednar bednar marked this pull request as ready for review August 12, 2024 05:55
@bednar bednar requested review from alespour and karel-rehor August 12, 2024 06:13
Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass locally and changes make sense. OK

@bednar bednar merged commit 13eb147 into main Aug 12, 2024
@bednar bednar deleted the fix-polars-serializer branch August 12, 2024 09:46
@bednar bednar added this to the 0.8.0 milestone Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Faulty import path for Polars Dataframe Serializer

3 participants