KEMBAR78
fix: #110 - set message 'processor was disposed' to level debug. by karel-rehor · Pull Request #111 · InfluxCommunity/influxdb3-python · GitHub
Skip to content

fix: #110 - set message 'processor was disposed' to level debug. #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2024
Merged

fix: #110 - set message 'processor was disposed' to level debug. #111

merged 2 commits into from
Sep 11, 2024

Conversation

@karel-rehor
Copy link
Contributor

@karel-rehor karel-rehor commented Sep 10, 2024 •
edited
Loading

Closes #110

Proposed Changes

  • Change logging level after disposal of batching processor to DEBUG.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@karel-rehor karel-rehor requested a review from bednar September 10, 2024 11:49
@codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.12%. Comparing base (9d92767) to head (8a4845f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
influxdb_client_3/write_client/client/write_api.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   55.12%   55.12%           
=======================================
  Files          33       33           
  Lines        2048     2048           
=======================================
  Hits         1129     1129           
  Misses        919      919

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bednar
bednar approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bednar bednar added this to the 0.9.0 milestone Sep 11, 2024
@bednar bednar merged commit e48744e into main Sep 11, 2024
13 of 14 checks passed
@bednar bednar deleted the fix/110-loglevel-proc-dispose branch September 11, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bednar bednar bednar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

Reduce logging level of batch processor disposition to DEBUG

2 participants

@karel-rehor @bednar