Rename and deprecate Window/DialogWindow overloads that create a ComposeWindow/ComposeDialog #2141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
approved these changes
May 28, 2025
| * limitations under the License. | ||
| */ | ||
|
|
||
| package androidx.compose.ui.window |
There was a problem hiding this comment.
I would move it to androidx.compose.ui.awt to be consistent with SwingPanel Composable and ComposeWindow class.
On the other hand, it will be inconsistent with AwtWindow, so we would have to move it too.
What do you think is better?
There was a problem hiding this comment.
Moved, and also improved some of the documentation on related functions.
m-sasha
force-pushed
the
m-sasha/rename-window-dialog-swing-overloads
branch
from
a44351f to
7fc722f
Compare
…oseWindow/ComposeDialog.
m-sasha
force-pushed
the
m-sasha/rename-window-dialog-swing-overloads
branch
from
7fc722f to
796da34
Compare
igordmn
approved these changes
Jun 2, 2025
|
@MatkovIvan Can you look at this too? Needs two reviewers here... |
MatkovIvan
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
Window/DialogWindowoverloads that create aComposeWindow/ComposeDialogtoSwingWindow/SwingDialogand deprecate the old names.This PR is meant to go before #2139, so we can keep consistent naming:
WindowandDialogWindow(yes, they're unfortunately still tied to Swing via e.g.WindowScope.window, but that's not intentional).SwingWindowandSwingDialog.I also cleaned up the
AppContentexamples file.Testing
Tested that the
ReplaceWithworks.Release Notes
Migration Notes - Desktop
WindowandDialogWindowoverloads that create aComposeWindow/ComposeDialoghave been renamed toSwingWindow/SwingDialogand the old versions have been deprecated.