Add WebElementView composable for embedding the absolutely positioned html content #2145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eymar
changed the title
MatkovIvan
requested changes
May 28, 2025
| WebClipboardDemo() | ||
| } | ||
| }, | ||
| HtmlInteropDemos |
There was a problem hiding this comment.
Can we use existing pages instead(or in addition)? Please use interop in mpp/demo/InteropOrder.web.kt
There was a problem hiding this comment.
I'd like to have a new set of specfic demo in this case.
Also I implemented TestInteropView. I see the order is not correct - doesn't match desktop - wip.
compose/ui/ui/src/jsMain/kotlin/androidx/compose/ui/viewinterop/WebElementView.js.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/webCommonW3C/kotlin/androidx/compose/ui/viewinterop/InteropView.wasmJs.kt
Outdated
Show resolved
Hide resolved
...se/ui/ui/src/webCommonW3C/kotlin/androidx/compose/ui/viewinterop/WebElementView.webCommon.kt
Show resolved
Hide resolved
...se/ui/ui/src/webCommonW3C/kotlin/androidx/compose/ui/viewinterop/WebElementView.webCommon.kt
Outdated
Show resolved
Hide resolved
...ui/src/webCommonW3C/kotlin/androidx/compose/ui/viewinterop/WebInteropElementHolder.wasmJs.kt
Outdated
Show resolved
Hide resolved
...ui/src/webCommonW3C/kotlin/androidx/compose/ui/viewinterop/WebInteropElementHolder.wasmJs.kt
Outdated
Show resolved
Hide resolved
...ui/ui/src/webCommonW3C/kotlin/androidx/compose/ui/viewinterop/WebInteropViewHolder.wasmJs.kt
Outdated
Show resolved
Hide resolved
...ui/ui/src/webCommonW3C/kotlin/androidx/compose/ui/viewinterop/WebInteropViewHolder.wasmJs.kt
Outdated
Show resolved
Hide resolved
...ui/src/webCommonW3C/kotlin/androidx/compose/ui/viewinterop/WebInteropElementHolder.wasmJs.kt
Outdated
Show resolved
Hide resolved
|
@SKom2 Hi! Could you please sign the contribution agreement https://cla.developers.google.com/clas using the same email as used in your commit with html interop? Oh I just noticed that you can't use that email anymore. Then we'll have to squash the commits. |
MatkovIvan
reviewed
Jun 3, 2025
...ui/src/webCommonW3C/kotlin/androidx/compose/ui/viewinterop/WebInteropElementHolder.wasmJs.kt
Outdated
Show resolved
Hide resolved
...ui/src/webCommonW3C/kotlin/androidx/compose/ui/viewinterop/WebInteropElementHolder.wasmJs.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/webCommonW3C/kotlin/androidx/compose/ui/window/ComposeWindow.web.kt
Show resolved
Hide resolved
compose/ui/ui/src/jsMain/kotlin/androidx/compose/ui/viewinterop/InteropView.js.kt
Show resolved
Hide resolved
eymar
force-pushed
the
ok/cfw_html_interop
branch
from
a154805 to
2d72747
Compare
MatkovIvan
approved these changes
Jun 3, 2025
Schahen
approved these changes
Jun 4, 2025
…le (boundsInRoot are is 0)
|
Note: updated the release notes after merging #2175 ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add WebElementView composable for embedding the absolutely positioned HTML content
Testing
This should be tested by QA
Release Notes
Highlights - Web
WebElementViewComposable function for embedding the absolutely positioned HTML content in Compose for web target. It's supported only when usingComposeViewportentry point and it's not supported withCanvasBasedWindow, which is deprecated now.