Support keepScreenOn modifier in uikit source set #2180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svastven
commented
Jun 16, 2025
...se/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/platform/UIKitKeepScreenOnManager.uikit.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
reviewed
Jun 16, 2025
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/platform/PlatformContext.skiko.kt
Outdated
Show resolved
Hide resolved
svastven
force-pushed
the
svastven/keep-screen-on
branch
2 times, most recently
from
15fe243 to
446d0d1
Compare
MatkovIvan
requested changes
Jun 18, 2025
compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/keepscreenon/KeepScreenOnManager.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/keepscreenon/KeepScreenOnManager.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/keepscreenon/KeepScreenOnManager.kt
Outdated
Show resolved
Hide resolved
svastven
force-pushed
the
svastven/keep-screen-on
branch
from
a425f5a to
bbf6c3c
Compare
MatkovIvan
approved these changes
Jun 20, 2025
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/platform/UIKitIdleTimerManager.kt
Show resolved
Hide resolved
ASalavei
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
keepScreenOnmodifier.keepScreenOnmodifier for iOS platform.Fixes - https://youtrack.jetbrains.com/issue/CMP-8296
Testing
This feature is tested by UIKit instrumented test.
This should be tested by QA
Release Notes
Features - iOS
keepScreenOnmodifier