Make PointerEventResult aware of anyChangeConsumed state besides anyMovementConsumed #2186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Jun 18, 2025
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/scene/ComposeScenePointer.skiko.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
PointerEventResult(marked as@InternalComposeUiApi) implementation to include the information aboutanyChangeConsumedbesidesanyMovementConsumedusing the bitmask.This fix is possible now after https://android-review.googlesource.com/c/platform/frameworks/support/+/3633065 is merged to our fork.
Fixes https://youtrack.jetbrains.com/issue/CMP-7520/CfW-back-gesture-interferes-with-Horizontal-Scroll
Testing
Added the tests for new properties.
Release Notes
Fixes - Web