Adopt the new context menu API for the web dropdown context menu #2224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trying it. I see some unexpected menu items duplications: 
I belive it happens because the SelectionContainer provides its own menu and TextField provides another menu. |
MatkovIvan
changed the title
I'm talking to the Googler working on context menus about this. We'll get it fixed on their end. |
m-sasha
approved these changes
Jul 9, 2025
Comment on lines
46
to
+50
| internal fun getString(string: Strings): String { | ||
| return getLocalizedString(string) | ||
| } | ||
|
|
||
| internal fun getLocalizedString(string: Strings): String { |
There was a problem hiding this comment.
Why keep both functions? If you think getLocalizedString is better, just rename it...
There was a problem hiding this comment.
it is for simplify the next merge with upstreamed changes. there is an expect composable function
|
The same happens on android with a cursor input: android text toolbar works unusual as well |
eymar
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt the new context menu API for the web dropdown context menu.
Can be enabled by
nwm.mp4
Fixes https://youtrack.jetbrains.com/issue/CMP-8433
Testing
This should be tested by QA
Release Notes
Features - Web