Query plugin provider for plugin by explicit attributes #1288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the plugin querying mechanism by adding a new method to query plugins via explicit criteria (plugin identifier, plugin name, and plugin aliases) and updating related classes and tests accordingly.
- Added tests for the new query functionality in IdePluginProviderTest.kt
- Introduced a PluginQuery builder and corresponding matcher in PluginQuery.java and PluginQueryMatcher.kt
- Updated the PluginProvider interface and Ide class to support the new query method
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| intellij-plugin-structure/tests/src/test/kotlin/com/jetbrains/plugin/structure/domain/IdePluginProviderTest.kt | Introduces tests for resolving plugins by ID, name, and alias |
| intellij-plugin-structure/structure-intellij/src/main/java/com/jetbrains/plugin/structure/intellij/plugin/PluginQuery.java | Adds a builder-based API for specifying query parameters |
| intellij-plugin-structure/structure-intellij/src/main/java/com/jetbrains/plugin/structure/intellij/plugin/PluginProvision.kt | Defines a sealed class representing the result of a plugin query |
| intellij-plugin-structure/structure-intellij/src/main/java/com/jetbrains/plugin/structure/intellij/plugin/PluginProvider.java | Updates the interface to include the new query method |
| intellij-plugin-structure/structure-ide/src/main/java/com/jetbrains/plugin/structure/ide/PluginQueryMatcher.kt | Implements matching logic between a plugin and a PluginQuery |
| intellij-plugin-structure/structure-ide/src/main/java/com/jetbrains/plugin/structure/ide/Ide.java | Integrates the query matcher and refactors the plugin identification logic |
Comments suppressed due to low confidence (1)
intellij-plugin-structure/structure-ide/src/main/java/com/jetbrains/plugin/structure/ide/PluginQueryMatcher.kt:13
- When multiple search criteria flags are enabled in PluginQuery, only the first matching condition is considered. Consider adding validation to ensure only one flag is set or document the precedence to avoid ambiguity.
fun matches(plugin: IdePlugin, query: PluginQuery): PluginProvision {
novotnyr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Semantics of
findPluginByModuleinPluginProvideris historically unclear. In this class, module might be a plugin alias or a content module ID.Add an additional method that allows to query plugins by searching in an explicit places: