Extract icon loading and dependency loading into separate class #1291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR extracts functionality for loading plugin icons and legacy 3rd party dependencies into separate loader classes to simplify PluginCreator.
- Introduces PluginIconLoader and ThirdPartyDependencyLoader classes.
- Adds tests for icon loading via PluginIconLoader.
- Updates IdePluginManager to utilize the new loader classes.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/src/test/kotlin/com/jetbrains/plugin/structure/intellij/plugin/loaders/PluginIconLoaderTest.kt | Adds tests validating that plugin icons (default and dark) are correctly loaded. |
| structure-intellij/src/main/java/com/jetbrains/plugin/structure/intellij/plugin/loaders/ThirdPartyDependencyLoader.kt | Adds a dedicated loader class for legacy 3rd party dependency loading. |
| structure-intellij/src/main/java/com/jetbrains/plugin/structure/intellij/plugin/loaders/PluginIconLoader.kt | Implements icon loading logic, mapping IconTheme values to file paths. |
| structure-intellij/src/main/java/com/jetbrains/plugin/structure/intellij/plugin/loaders/PluginDirectoryResourceLoader.kt | Provides a common interface for resource loaders. |
| structure-intellij/src/main/java/com/jetbrains/plugin/structure/intellij/plugin/IdePluginManager.kt | Refactors plugin info loading to use the new resource loaders instead of inlined logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to simplify
PluginCreator, extract the following functionality to separate class: